[merged after dec 5th] adds new hard_deletes config #6558
+228
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
commented
Nov 27, 2024
| | 1 | b1885d098f8bcff53... | shipped | 2024-10-02 ... | 2024-06-03 ... | | False | | ||
| | 2 | b1885d098f8bcff55... | active | 2024-10-02 ... | 2024-05-19 ... | | False | | ||
|
|
||
| In this example, the `dbt_is_deleted` column is set to `True` when the record is deleted. When the record is restored, the `dbt_is_deleted` column is set to `False`. |
There was a problem hiding this comment.
would love a gut check if this is right bc I've been reading this over and over again so might have mixed things up.
graciegoheen
requested changes
Nov 27, 2024
website/docs/reference/resource-configs/snapshot_meta_column_names.md
Outdated
Show resolved
Hide resolved
| | -- | -------------------- | -------------------- | -------------------- | -------------------- | | ||
| | 1 | 60a1f1dbdf899a4dd... | 2024-10-02 ... | 2024-10-02 ... | 2024-10-02 ... | | ||
| | 2 | b1885d098f8bcff51... | 2024-10-02 ... | 2024-10-02 ... | | | ||
| | id | scd_id | modified_date | start_date | end_date | is_deleted | |
There was a problem hiding this comment.
same comment as earlier
There was a problem hiding this comment.
i changed it to the below but also wasn't sure if it made sense to go into hard_deletes:'new_record' detail since this page is about meta column names?
| id | scd_id | modified_date | start_date | end_date | is_deleted |
|---|---|---|---|---|---|
| 1 | 60a1f1dbdf899a4dd... | 2024-10-02 ... | 2024-10-02 ... | 2024-10-03 ... | False |
| 1 | 60a1f1dbdf899a4dd... | 2024-10-03 ... | 2024-10-03 ... | True | |
| 2 | b1885d098f8bcff51... | 2024-10-02 ... | 2024-10-02 ... | False |
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
…ames.md Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
….9.md Co-authored-by: Grace Goheen <[email protected]>
Co-authored-by: Grace Goheen <[email protected]>
…tdbt.com into add-hard-deletes-config
graciegoheen
reviewed
Dec 2, 2024
| [snapshot_meta_column_names](/reference/resource-configs/snapshot_meta_column_names): dictionary | ||
| [dbt_valid_to_current](/reference/resource-configs/dbt_valid_to_current): string | ||
| [hard_deletes](/reference/resource-configs/hard-deletes): string |
There was a problem hiding this comment.
i wonder if instead of saying "string" here, we should say something like ignore | invalidate | new_record so it's clear what your options are?
| | -- | ------ | ---------- | -------------- | ------------ | -------------- | | ||
| | 1 | pending | 2024-01-01 10:47 | 2024-01-01 10:47 | 2024-01-01 11:05 | False | | ||
| | 1 | shipped | 2024-01-01 11:05 | 2024-01-01 11:05 | 2024-01-01 11:20 | False | | ||
| | 1 | shipped | 2024-01-01 11:20 | 2024-01-01 11:20 | | True | |
There was a problem hiding this comment.
This row should have a dbt_valid_to set to 2024-01-01 12:00 (the time that the "undeleted" record is now valid at)
graciegoheen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds the new
hard_deletesconfig, which replacesinvalidates_hard_deletes.added in multiple pages such as snapshots, snapshot config, new hard_deletes page, upgrade guide, and release note.
This needs to be merged after Dec 5th
Resolves #6522
🚀 Deployment available! Here are the direct links to the updated files: